HYDRA-1043 : Fix Bifrost graphs can't be displayed in Hydra viewport #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI : @ppt-adsk @debloip-adsk |
|
BTW: no unit test is added as we don't support Bifrost yet in automation, but a ticket is logged for that. |
|
Locally the the tests pass. I don't know why I get segment faults and random failures with the tests. Giving it another try. |
… are not all supported.
lilike-adsk
reviewed
Sep 19, 2024
| @@ -45,15 +46,14 @@ def test_MayaDefaultMaterial(self): | |||
| cmds.refresh() | |||
| self.assertSnapshotClose("defaultMaterial" + ".png", self.IMAGE_DIFF_FAIL_THRESHOLD, self.IMAGE_DIFF_FAIL_PERCENT) | |||
|
|
|||
| @unittest.skipUnless(platform.system() != "Darwin", 'This test is disabled on OSX as not all implicit surfaces are fully implemented on OSX.') | |||
There was a problem hiding this comment.
Who will support them on OSX? If it's us, should we track via a ticket?
There was a problem hiding this comment.
I don't think we should take the ownership of those on OSX.
We should see if a ticket is logged in OpenUSD about that and if not log one.
There was a problem hiding this comment.
I created PixarAnimationStudios/OpenUSD#3305 in the OpenUSd github to see if there is already something logged.
lilike-adsk
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.